OSD lab6 blog post

During this lab, I found that the Brave browser will fail to search or open the correct content for the two url:
  • "https://www.google.ca/search?q=dog cat"
  • "file:///Users/humphd/repos/browser-laptop/dog cat.txt"

they all have a space between dog and cat, and because of that, the browser will consider they are not a valid url. I tried to fix this bug.

I found when they check the url, they only trim the spaces at beginning and end. The space between dog and cat won't be replace or encoded as an url. So, I added the code.

And I wrote test cases:

As well as ran the unit test:

Comments

Post a Comment

Popular posts from this blog

Analyzing bugs for vscode on Github

Image
For the OSD600 lab3, I am trying to fix a bug for vscode. I found this bug in the issues tab,  Rename folder collapses it . The reporter illustrated clearly that when renaming the parent folder of a structure of folders, the folder tree collapsed. I analyzed the code and tried to fix it. I found that it actually deleting the folder structure first and then re-add them to the view with the new name. When rename the folder name: The folders get deleted one by one Then it will re-add it with new folder name  This is the code that has been doing the action. I don't know why it's done this way, but certainly there's reason for that. What I can do is to add code to expand the folders after they got added to the view.
Read more

OSD release 0.2 final post

Image
This was a valuable learning experience of working with the  issue  on Mozilla/devtools:  debugger.html . The issue was related to adding flow coverage for one of the type.js file. At beginning, I did not think it will be a hard process, just need to learned flow as I supposed to. However, it was actually not that easy because I ran into many troubles like figuring out the meaning of the code and make good adjustment for fixing. Thankfully, after I push my PR on GitHub,  here , Jason, the owner of debugger repo helped a lot. He fixed last three errors which really need deep understanding of the code. However, we all ran into the last problem, which is shown in the screenshots below, This error is tough because I am not sure what is it causing it. By doing some research, it might be flow itself causing the error. So, Jason asked me to created another PR just for debugging this error and merged other code to the master branch. Overall, my first contribution to open source projec
Read more

Building the vscode

I forked the vscode repository from Microsoft's Github. It is a very popular editor nowadays and I want to make some contributions to it hopefully.  The building process was simple and straight forward. I followed the instruction on the official readme and install all the dependencies. Although there was some troubles such as the version issue of python on my Mac, I was still able to make it through. It's quite amazing to see the whole building process of vscode and finally the editor window pops up.
Read more